Skip to content

feat(27601): Copy JSDoc from type when destructing arguments #46886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2022
Merged

feat(27601): Copy JSDoc from type when destructing arguments #46886

merged 1 commit into from
Feb 3, 2022

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Nov 21, 2021

Fixes #27601

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Nov 21, 2021
@andreialecu
Copy link

andreialecu commented Jan 19, 2022

Was wondering if there's anything blocking this?

This would be a great quality of life DX improvement, especially in the React ecosystem where destructuring is very prevalent.

Also related:

microsoft/vscode#76592

#27942
#27601
#24045
#24746
#11859
mhkeller/layercake#56 (comment)

@a-tarasyuk
Copy link
Contributor Author

a-tarasyuk commented Jan 19, 2022

@andreialecu I think it's better to address this question to @RyanCavanaugh ;). This issue is not part of 4.6 milestone. I think need to wait a bit.

sandersn
sandersn requested changes Jan 28, 2022
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a union test.

@a-tarasyuk a-tarasyuk requested a review from sandersn January 29, 2022 20:52
@sandersn sandersn merged commit 0d5abd8 into microsoft:main Feb 3, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn sandersn sandersn approved these changes

Assignees

No one assigned

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Copy JSDoc from type when destructing arguments.

4 participants

@a-tarasyuk @andreialecu @sandersn @typescript-bot